Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide libcurl internally instead of wrapping #168

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Hind-M
Copy link
Member

@Hind-M Hind-M commented Feb 16, 2023

Fix #159

TODO:

Two points still need to be handled (maybe after completing powerloader integration in mamba? - mostly for the first one):

  • ssl_backend_t enum conversion to use outside powerloader.
  • progress_callback_t = std::function<int(curl_off_t, curl_off_t)> in download_target.hpp is apparently used in mamba with std::size_t instead of curl_off_t. So I don't see why curl_off_t is used here.
    If there is no specific reason, it should directly use std::size_t.

@Hind-M Hind-M self-assigned this Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make libcurl a private dependency
1 participant